Re: [PATCH] 2.5.21 kill warnings 4/19

Greg KH
2002-06-11T06:42:39Z

On Tue, Jun 11, 2002 at 08:33:18AM +0200, Martin Dalecki wrote:
> Greg KH wrote:
> >On Mon, Jun 10, 2002 at 01:26:53PM +0200, Martin Dalecki wrote:
> >
> >>Fix improper usage of __FUNCTION__ in usb code.
> >
> >
> >It's not improper. Well it wasn't when it was written, but the gcc
> >authors decided to change their minds... :(
> >
> >As stated before, I'll clean up all of the USB drivers later all at
> >once, and the pci hotplug drivers as well. The USB drivers could use
> >with some good debugging macro cleanup in general...
> >
> >Martin, any reason you are doing all of this "cleanup" without sending
> >the patches to the relevant maintainers?
>
> 1. I know you read lkml.

Yeah, but not all the other maintainers do, it's still good form to at
least CC: them on things like this.

And remember, other maintainers aren't as nice as I am :)

greg k-h