Re: [PATCH] Replace timer_bh with tasklet

kuznet
2002-06-18T18:30:23Z

Hello!

> > But this is impossible, timers must not race with another BHs,
> > all the code using BHs depends on this. That's why they are BHs.
>
> If indeed they do "race" the old code had the timer_bh being first.
> So does this patch.

I do not understand what you mean here.

I feel you misunderstand my comment. I said the patch is one pure big bug,
because tasklets are not serialized wrt BHs. Timer MUST. If you are going
to get rid of this must, start from editing all the code which makes this
assumption.

> This is one of the most hard to control paths in the system as ALL it
> does is execute functions that are unknown as to size, duration, etc.
> One would hope that they never run for long, but...

Pardon, your code has an effect only after this "but..." happens
and this effect is insane.

> Not really. One REALLY expects timers to expire in timed order :) Using
> a separate procedure to deliver a timer just because it is of a different
> resolution opens one up to a world of pathology.

Are you going to mix use of hires and lores timers for one task?

Alexey