Re: [patch] scheduler bits from 2.5.23-dj1

Robert Love
2002-06-19T23:47:11Z

On Wed, 2002-06-19 at 16:35, Ingo Molnar wrote:

> the scheduler optimisation in 2.5.23-dj1, from James Bottomley, look fine
> to me. I did some modifications:

Nice.

> +static inline unsigned int task_cpu(struct task_struct *p)
> +static inline unsigned int set_task_cpu(struct task_struct *p, unsigned int cpu)

Technically, shouldn't we make these `unsigned long' ?

I know on x86 we store cpu as a `u32' so it does not matter per se, but
in reality it is an unsigned long and other architectures may export it
as such.

Further, we compare and set it against the various CPU bitmaps and they
are all `unsigned long' and we do shifts against 1UL ...

Robert Love