From: Martin Dalecki <dalecki@evision-ventures.com>
To: Jens Axboe <axboe@suse.de>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>,
Paul Bristow <paul@paulbristow.net>,
Gadi Oxman <gadio@netvision.net.il>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.5.22] simple ide-tape.c and ide-floppy.c cleanup
Date: Thu, 20 Jun 2002 11:16:11 +0200 [thread overview]
Message-ID: <3D119D5B.8060202@evision-ventures.com> (raw)
In-Reply-To: 20020620054230.GK812@suse.de
Użytkownik Jens Axboe napisał:
> On Wed, Jun 19 2002, Bartlomiej Zolnierkiewicz wrote:
>
> Looks pretty good in general, just one minor detail:
>
>
>>+
>>+/*
>>+ * ATAPI packet commands.
>>+ */
>>+#define ATAPI_FORMAT_UNIT_CMD 0x04
>>+#define ATAPI_INQUIRY_CMD 0x12
>
>
> [snip]
>
> We already have the "full" list in cdrom.h (GPCMD_*), so lets just use
> that. After all, ATAPI_MODE_SELECT10_CMD _is_ the same as the SCSI
> variant (and I think the _CMD post fixing is silly, anyone familiar with
> this is going to know what ATAPI_WRITE10 means just fine)
>
> Same for request_sense, that is already generalized in cdrom.h as well.
I wonder what FreeBSD is using here? I see no need for invention at
this place.
next prev parent reply other threads:[~2002-06-20 9:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-19 21:45 [PATCH 2.5.22] simple ide-tape.c and ide-floppy.c cleanup Bartlomiej Zolnierkiewicz
2002-06-20 5:42 ` Jens Axboe
2002-06-20 9:16 ` Martin Dalecki [this message]
2002-06-20 9:19 ` Jens Axboe
2002-06-20 9:22 ` Martin Dalecki
2002-06-20 16:37 ` Bartlomiej Zolnierkiewicz
2002-06-20 16:41 ` Martin Dalecki
2002-06-20 16:44 ` Jens Axboe
2002-06-20 16:50 ` Bartlomiej Zolnierkiewicz
2002-06-20 17:26 ` Jens Axboe
2002-06-20 21:05 ` [redone PATCH 2.5.22] simple ide-tape/floppy.c cleanup Bartlomiej Zolnierkiewicz
2002-06-21 0:22 ` Martin Dalecki
-- strict thread matches above, loose matches on Subject: below --
2002-07-03 15:51 [PATCH 2.5.22] simple ide-tape.c and ide-floppy.c cleanup Eduard Bloch
2002-07-03 18:03 ` Bartlomiej Zolnierkiewicz
2002-07-08 4:23 ` Martin Dalecki
2002-07-08 20:33 ` Paul Bristow
2002-07-08 21:41 ` Andre Hedrick
2002-07-08 21:56 ` Bartlomiej Zolnierkiewicz
2002-07-09 12:28 ` Martin Dalecki
2002-07-09 12:46 ` Bartlomiej Zolnierkiewicz
[not found] <mailman.1025711581.26152.linux-kernel2news@redhat.com>
2002-07-03 20:18 ` Pete Zaitcev
2002-07-03 22:09 ` Andre Hedrick
2002-07-03 22:21 James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D119D5B.8060202@evision-ventures.com \
--to=dalecki@evision-ventures.com \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=axboe@suse.de \
--cc=gadio@netvision.net.il \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paulbristow.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox