public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Aspert <Nicolas.Aspert@epfl.ch>
To: Dave Jones <davej@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] Split up agpgart into per implementation files.
Date: Thu, 20 Jun 2002 14:49:45 +0200	[thread overview]
Message-ID: <3D11CF69.3030103@epfl.ch> (raw)
In-Reply-To: fa.ep8m4pv.1gkki2v@ifi.uio.no

Dave Jones wrote:

 > There's lots more that can be done to cut down some of the duplication
 > that this patch introduces, but it's a good start at making the
 > backend code a little easier to navigate.
 >
 > Comments?
 >

Definitely a good idea !
The code is much easier to read.

For those interested in trying this with 2.4, here is an adaptation of 
the patch for 2.4.19-pre10-ac2 . I did not include neither the changes 
made in 2.5.23 (at least they should not be here), nor the intel 460 
stuff (not present in 2.4).

You can find the patch at :
http://ltswww.epfl.ch/~aspert/patches/agpgart-split-2.4.19-pre10-ac2.diff.bz2

For those using kbuild, a replacement for the Makefile.in in 
'drivers/char/agp' can be found at :
http://ltswww.epfl.ch/~aspert/patches/Makefile.in

Please test (it compiles OK but I don't have a test box at hand)

a+
-- 
Nicolas Aspert      Signal Processing Institute (ITS)
Swiss Federal Institute of Technology (EPFL)



       reply	other threads:[~2002-06-20 12:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.ep8m4pv.1gkki2v@ifi.uio.no>
2002-06-20 12:49 ` Nicolas Aspert [this message]
2002-06-20 14:06   ` [PATCH] Split up agpgart into per implementation files Dave Jones
2002-06-20 14:32     ` Nicolas Aspert
2002-06-19 16:19 Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D11CF69.3030103@epfl.ch \
    --to=nicolas.aspert@epfl.ch \
    --cc=davej@suse.de \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox