Re: [PATCH] 2.5.24 : drivers/net/defxx.c

Frank Davis
2002-06-24T15:32:08Z

Zwane,
I agree, although eventually I envision the code to look like...

if(pci_set_dma_mask(pdev, 0xffffffff))
{
printk(KERN_WARNING "defxx : No suitable DMA available\n");
// Add appropriate action, such as
// goto err_dma_exit;
// OR
return -ENOMEM;
}

Thats why I have the braces (multiple statements).

Regards,
Frank

> Zwane Mwaikambo wrote:
>
>> On Sun, 23 Jun 2002, Frank Davis wrote:
>>
>>
>>> -
>>> + if(pci_set_dma_mask(pdev, 0xffffffff))
>>> + {
>>> + printk(KERN_WARNING "defxx : No suitable DMA available\n");
>>> + }
>>
>>
>>
>> Minor nit,
>> CodingStyle prefers this style;
>>
>> if (pci_set_dma_mask(pdev, 0xffffffff))
>> printk(KERN_WARNING "defxx : No suitable DMA available\n");
>>
>> Thanks,
>> Zwane Mwaikambo
>>
>
>