public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Patrick Mochel <mochel@osdl.org>
Cc: Nick Bellinger <nickb@attheoffice.org>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: driverfs bus_id, name (was: [PATCH] /proc/scsi/map)
Date: Tue, 25 Jun 2002 10:47:07 -0700	[thread overview]
Message-ID: <3D18AC9B.8050306@pacbell.net> (raw)
In-Reply-To: Pine.LNX.4.33.0206250920150.8496-100000@geena.pdx.osdl.net

 > The bus_id of the device is intended to represent the bus-specific ID of
 > the device, and is the name of the driverfs directory.

Right, I was just commenting that the SCSI folk seem to like a particular
historical usage (based on driver enumeration order) that'd seem good to
do away with ... since it's not necessary (given the _real_ bus-specific
ID from their parent device) and has _always_ been problematic (those
enumeration-related IDs can change unexpectedly).


 > The name should user-friendly. It shouldn't be a unique name. Use
 > something nice and pretty.

I've been wondering about that.  Right now PCI and USB both use fairly
unfriendly/unpretty values in device.name ... "{PCI,USB} device VVVV:PPPP".

Let me make sure I understand you right here, by examples of two
changes I'd like to see.  Correct me if these seem wrong:

- It'd be more appropriate for PCI devices to copy pci_device.name into
   device.name and get the user-friendly names from the PCI device name
   database (when available), and only fallback to those nasty strings
   when the more user-friendly names aren't available.

- Likewise it'd be more appropriate for USB devices to take the
   descriptive strings from the devices, like "Philips USB Digital
   Speaker System", than "USB device 0471:0104".

In both cases the current strings might make reasonable fallbacks
for the case when something better isn't available.  But as examples,
I don't think they match a "user friendly, pretty" model ... :)

Would it be appropriate for device drivers to set the "name" in
some cases, or is that something you'd only expect bus drivers
to be setting up (once, and read-only)?

Given that in one common usage the "bus_id" is the "true name" of
those devices, I've thought that "description" might be a slightly
better way identify that attribute.  "Name" is a word with a thousand
meanings, all of them context-dependent, and easily confused.

- Dave






  reply	other threads:[~2002-06-25 17:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-22 17:24 [PATCH] /proc/scsi/map David Brownell
2002-06-22 17:48 ` Roman Zippel
2002-06-22 20:11   ` Douglas Gilbert
2002-06-22 20:57     ` Roman Zippel
2002-06-22 18:18 ` Nick Bellinger
2002-06-24  1:50   ` David Brownell
2002-06-25 16:46   ` Patrick Mochel
2002-06-25 16:33 ` Patrick Mochel
2002-06-25 17:47   ` David Brownell [this message]
2002-06-25 19:06     ` driverfs bus_id, name (was: [PATCH] /proc/scsi/map) Patrick Mochel
2002-06-25 19:55       ` David Brownell
2002-07-01 17:25         ` Patrick Mochel
2002-06-25 17:49   ` [PATCH] /proc/scsi/map David Brownell
2002-06-26 23:39     ` Nick Bellinger
2002-07-01 17:45       ` Patrick Mochel
2002-07-03  0:59     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D18AC9B.8050306@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mochel@osdl.org \
    --cc=nickb@attheoffice.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox