public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Dobson <colpatch@us.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Michael Hohnbaum <hbaum@us.ibm.com>, Ingo Molnar <mingo@elte.hu>
Subject: [patch] boot hang on multi-quad machines.
Date: Tue, 25 Jun 2002 17:20:52 -0700	[thread overview]
Message-ID: <3D1908E4.8030404@us.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

As mentioned in several posts, the balance_irq code introduced in 2.5.9 is 
broken for any architecture that doesn't use flat logical addressing.  Also, 
even when it does work, there have been several reports of it degrading 
performance.  As the NUMA-Q architecture I work with doesn't use flat logical 
addressing, and it isn't worth the possible performance hit, I'm submitting 
this patch for inclusion into the mainline.

Cheers!

-Matt


[-- Attachment #2: balance_irq-fix.patch --]
[-- Type: text/plain, Size: 358 bytes --]

--- linux-2.5.21-vanilla/arch/i386/kernel/io_apic.c	Fri Jun 14 17:17:44 2002
+++ linux-2.5.21-patched/arch/i386/kernel/io_apic.c.fixed	Mon Jun 24 17:54:20 2002
@@ -247,7 +247,7 @@
 
 static inline void balance_irq(int irq)
 {
-#if CONFIG_SMP
+#if (CONFIG_SMP && !CONFIG_MULTIQUAD)
 	irq_balance_t *entry = irq_balance + irq;
 	unsigned long now = jiffies;
 

                 reply	other threads:[~2002-06-26  0:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D1908E4.8030404@us.ibm.com \
    --to=colpatch@us.ibm.com \
    --cc=hbaum@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox