From: Andrew Morton <akpm@zip.com.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [patch 22/27] ext3 truncate fix
Date: Thu, 04 Jul 2002 16:55:08 -0700 [thread overview]
Message-ID: <3D24E05C.4D57A492@zip.com.au> (raw)
Forward-port of a fix which Stephen has applied to ext3's 2.4 CVS tree.
Fix for a rare problem seen under stress in data=journal mode: if we
have to restart a truncate transaction while traversing the inode's
direct blocks, we need to deal with bh==NULL in ext3_clear_blocks.
inode.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
--- 2.5.24/fs/ext3/inode.c~ext3-truncate-fix Thu Jul 4 16:17:31 2002
+++ 2.5.24-akpm/fs/ext3/inode.c Thu Jul 4 16:17:31 2002
@@ -1632,8 +1632,10 @@ ext3_clear_blocks(handle_t *handle, stru
}
ext3_mark_inode_dirty(handle, inode);
ext3_journal_test_restart(handle, inode);
- BUFFER_TRACE(bh, "get_write_access");
- ext3_journal_get_write_access(handle, bh);
+ if (bh) {
+ BUFFER_TRACE(bh, "retaking write access");
+ ext3_journal_get_write_access(handle, bh);
+ }
}
/*
-
reply other threads:[~2002-07-04 23:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D24E05C.4D57A492@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox