From: Andrew Morton <akpm@zip.com.au>
To: kuznet@ms2.inr.ac.ru
Cc: linux-kernel@vger.kernel.org
Subject: Re: readprofile from 2.5.25 web server benchmark
Date: Tue, 09 Jul 2002 13:25:02 -0700 [thread overview]
Message-ID: <3D2B469E.766C856E@zip.com.au> (raw)
In-Reply-To: 200207091030.OAA22445@sex.inr.ac.ru
kuznet@ms2.inr.ac.ru wrote:
>
> Hello!
>
> > --- 2.5.25/kernel/timer.c~timer-speedup Tue Jul 9 00:04:33 2002
> > +++ 2.5.25-akpm/kernel/timer.c Tue Jul 9 00:06:09 2002
> > @@ -211,6 +211,9 @@ int mod_timer(struct timer_list *timer,
> > int ret;
> > unsigned long flags;
> >
> > + if (timer_pending(timer) && timer->expires == expires)
> > + return 1;
> > +
> > spin_lock_irqsave(&timerlist_lock, flags);
> > timer->expires = expires;
> > ret = detach_timer(timer);
>
> Does this not lose timer sometimes?
>
Well I've thought about it long and hard, but I can't see a
hole. But there probably is one. Somewhere.
It reduces mod_timer() load by 30% in a netperf run, so it's
worth thinking about.
-
next prev parent reply other threads:[~2002-07-09 20:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-09 6:23 readprofile from 2.5.25 web server benchmark Dave Hansen
2002-07-09 6:44 ` Andrew Morton
2002-07-09 6:49 ` Dave Hansen
2002-07-09 7:06 ` Andrew Morton
2002-07-09 10:30 ` kuznet
2002-07-09 20:25 ` Andrew Morton [this message]
2002-07-09 21:14 ` kuznet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D2B469E.766C856E@zip.com.au \
--to=akpm@zip.com.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox