public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: jgarzik@mandrakesoft.com, linux-kernel@vger.kernel.org,
	Dave Jones <davej@suse.de>
Subject: Re: 2.5: smc9194.c + smc-ircc.c: multiple definition of `smc_init'
Date: Tue, 09 Jul 2002 13:32:59 -0700	[thread overview]
Message-ID: <3D2B487B.FC24E2E@zip.com.au> (raw)
In-Reply-To: Pine.NEB.4.44.0207091203270.20908-100000@mimas.fachschaften.tu-muenchen.de

Adrian Bunk wrote:
> 
> ...
> irda/built-in.o: In function `smc_init':
> irda/built-in.o(.text.init+0x1624): multiple definition of `smc_init'
> smc9194.o(.text.init+0x0): first defined here
> ld: Warning: size of symbol `smc_init' changed from 101 to 10 in
> irda/built-in.o

yup.   There's an smc_init() in drivers/net/irda/smc-ircc.c and
another in drivers/net/smc9194.c.  The latter cannot be made static
because drivers/net/Space.c refers to it.  But we can make the irda
one static.

And yes, 2.5.25 needs this.

--- 2.5.25/drivers/net/irda/smc-ircc.c~smc-init	Tue Jul  9 13:28:51 2002
+++ 2.5.25-akpm/drivers/net/irda/smc-ircc.c	Tue Jul  9 13:28:53 2002
@@ -1203,7 +1203,7 @@ static int __exit ircc_close(struct ircc
 	return 0;
 }
 
-int __init smc_init(void)
+static int __init smc_init(void)
 {
 	return ircc_init();
 }

-

      reply	other threads:[~2002-07-09 20:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-09 10:09 2.5: smc9194.c + smc-ircc.c: multiple definition of `smc_init' Adrian Bunk
2002-07-09 20:32 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D2B487B.FC24E2E@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=bunk@fs.tum.de \
    --cc=davej@suse.de \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox