* [PATCH] AFFS fix return without releasing BKL
@ 2002-07-11 7:28 Dave Hansen
2002-07-11 20:44 ` Roman Zippel
0 siblings, 1 reply; 3+ messages in thread
From: Dave Hansen @ 2002-07-11 7:28 UTC (permalink / raw)
To: Linus Torvalds; +Cc: zippel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 252 bytes --]
Linus,
This was found by Dan Carpenter <error27@email.com>, using an smatch
script. Looks to me like like an error caused during all the BKL
pushing. 1 more coming...
Not tested (Greg, please don't hurt me :p )
--
Dave Hansen
haveblue@us.ibm.com
[-- Attachment #2: affs-bkl_ret-2.5.25-0.patch --]
[-- Type: text/plain, Size: 320 bytes --]
--- linux-2.5.25-clean/fs/affs/namei.c Thu Jun 20 15:53:49 2002
+++ linux/fs/affs/namei.c Thu Jul 11 00:15:16 2002
@@ -345,8 +345,10 @@
lock_kernel();
/* WTF??? */
- if (!dentry->d_inode)
+ if (!dentry->d_inode) {
+ unlock_kernel();
return -ENOENT;
+ }
res = affs_remove_header(dentry);
unlock_kernel();
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] AFFS fix return without releasing BKL
2002-07-11 7:28 [PATCH] AFFS fix return without releasing BKL Dave Hansen
@ 2002-07-11 20:44 ` Roman Zippel
2002-07-12 19:06 ` Dave Hansen
0 siblings, 1 reply; 3+ messages in thread
From: Roman Zippel @ 2002-07-11 20:44 UTC (permalink / raw)
To: Dave Hansen; +Cc: linux-kernel
Hi,
On Thu, 11 Jul 2002, Dave Hansen wrote:
> This was found by Dan Carpenter <error27@email.com>, using an smatch
> script. Looks to me like like an error caused during all the BKL
> pushing. 1 more coming...
Actually lock_kernel() and the test there can be removed completely.
bye, Roman
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] AFFS fix return without releasing BKL
2002-07-11 20:44 ` Roman Zippel
@ 2002-07-12 19:06 ` Dave Hansen
0 siblings, 0 replies; 3+ messages in thread
From: Dave Hansen @ 2002-07-12 19:06 UTC (permalink / raw)
To: Roman Zippel; +Cc: linux-kernel, Linus Torvalds
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]
Roman Zippel wrote:
> Hi,
>
> On Thu, 11 Jul 2002, Dave Hansen wrote:
>
>>This was found by Dan Carpenter <error27@email.com>, using an smatch
>>script. Looks to me like like an error caused during all the BKL
>>pushing. 1 more coming...
>
> Actually lock_kernel() and the test there can be removed completely.
Patch attached to do just that.
--
Dave Hansen
haveblue@us.ibm.com
[-- Attachment #2: affs-bkl_ret-2.5.25-1.patch --]
[-- Type: text/plain, Size: 405 bytes --]
--- linux-2.5.25-clean/fs/affs/namei.c Thu Jun 20 15:53:49 2002
+++ linux/fs/affs/namei.c Fri Jul 12 12:05:24 2002
@@ -342,14 +342,7 @@
pr_debug("AFFS: rmdir(dir=%u, \"%.*s\")\n", (u32)dir->i_ino,
(int)dentry->d_name.len, dentry->d_name.name);
- lock_kernel();
-
- /* WTF??? */
- if (!dentry->d_inode)
- return -ENOENT;
-
res = affs_remove_header(dentry);
- unlock_kernel();
return res;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-07-12 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-07-11 7:28 [PATCH] AFFS fix return without releasing BKL Dave Hansen
2002-07-11 20:44 ` Roman Zippel
2002-07-12 19:06 ` Dave Hansen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox