* [patch 2/13] leave truncate's orphaned pages on the LRU
@ 2002-07-17 5:29 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2002-07-17 5:29 UTC (permalink / raw)
To: Linus Torvalds; +Cc: lkml
Fix to the page reclaim code from Rik.
Anonymous pages which have buffers arise when
truncate_complete_page()'s call to ->releasepage() failed. Those pages
may still be mapped into process address spaces.
We should not remove them from the LRU, because that makes them
unswappable and they hang around until process exit.
vmscan.c | 12 ++----------
1 files changed, 2 insertions(+), 10 deletions(-)
--- 2.5.26/mm/vmscan.c~rmap-lru-fix Tue Jul 16 21:46:28 2002
+++ 2.5.26-akpm/mm/vmscan.c Tue Jul 16 21:59:41 2002
@@ -235,19 +235,11 @@ shrink_cache(int nr_pages, zone_t *class
if (try_to_release_page(page, gfp_mask)) {
if (!mapping) {
- /*
- * We must not allow an anon page
- * with no buffers to be visible on
- * the LRU, so we unlock the page after
- * taking the lru lock
- */
- spin_lock(&pagemap_lru_lock);
- unlock_page(page);
- __lru_cache_del(page);
-
/* effectively free the page here */
+ unlock_page(page);
page_cache_release(page);
+ spin_lock(&pagemap_lru_lock);
if (--nr_pages)
continue;
break;
.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-07-17 5:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-07-17 5:29 [patch 2/13] leave truncate's orphaned pages on the LRU Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox