From: "H. Peter Anvin" <hpa@zytor.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, Art Haas <ahaas@neosoft.com>
Subject: Re: Remain Calm: Designated initializer patches for 2.5
Date: Thu, 18 Jul 2002 02:34:22 -0700 [thread overview]
Message-ID: <3D368B9E.1070208@zytor.com> (raw)
In-Reply-To: 20020718085813.8DF8C41A3@lists.samba.org
Rusty Russell wrote:
> In message <3D366103.8010403@zytor.com> you write:
>
>>As far as I could tell, *ALL* of these changes broke text alignment in
>>columns.
>
>
> True.
>
>
>>It would have been a lot better if they had maintained spacing; I
>>find the new code much more cluttered and hard to read.
>
>
> I thought about this: I agree it doesn't look as neat, but "hard to
> read" for what purpose? It's just as easy to find a particular field
> you're looking for and it's just as easy to find the end of the
> declaration: I couldn't come up with a convincing argument for needing
> to skim-read these declarations, so I didn't complain to the author.
>
Neatness is about making it easy to read code *quickly*. The pattern
recognizer in your brain doesn't work as well on a jumbled mess.
-hpa
next prev parent reply other threads:[~2002-07-18 9:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-18 3:22 Remain Calm: Designated initializer patches for 2.5 Rusty Russell
2002-07-18 3:32 ` Arnaldo Carvalho de Melo
2002-07-18 7:42 ` Rusty Russell
2002-07-18 6:32 ` H. Peter Anvin
2002-07-18 6:28 ` David S. Miller
2002-07-18 6:40 ` H. Peter Anvin
2002-07-18 6:53 ` Arnaldo Carvalho de Melo
2002-07-18 6:56 ` H. Peter Anvin
2002-07-18 7:33 ` Anton Altaparmakov
2002-07-18 7:46 ` Rusty Russell
2002-07-18 9:34 ` H. Peter Anvin [this message]
2002-07-18 13:47 ` Daniel Phillips
2002-07-19 1:32 ` Rusty Russell
2002-07-19 7:31 ` Marcin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D368B9E.1070208@zytor.com \
--to=hpa@zytor.com \
--cc=ahaas@neosoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox