From: Andrew Morton <akpm@zip.com.au>
To: Stephen Lord <lord@sgi.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: O_DIRECT read and holes in 2.5.26
Date: Sun, 21 Jul 2002 19:26:31 -0700 [thread overview]
Message-ID: <3D3B6D57.BB5C0F38@zip.com.au> (raw)
In-Reply-To: 1026981790.1258.17.camel@localhost.localdomain
Stephen Lord wrote:
>
> Andrew,
>
> Did you realize that the new O_DIRECT code in 2.5 cannot read over holes
> in a file.
Well that was intentional, although I confess to not having
put a lot of thought into the decision. The user wants
O_DIRECT and we cannot do that. The CPU has to clear the
memory by hand. Bad.
Obviously it's easy enough to put in the code to clear the
memory out. Do you think that should be done?
> The old code filled the user buffer with zeros, the new code
> returned EINVAL if the getblock function returns an unmapped buffer.
> With this exception, XFS does work with the new code - with more cpu
> overhead than before due to the once per page getblock calls.
OK, thanks. Presumably XFS has a fairly heavyweight get_block()?
I'd be interested in seeing just how expensive that O_DIRECT
I/O is, and whether we need to get down and implement a
many-block get_block() interface. Any numbers/profiles
available?
-
next prev parent reply other threads:[~2002-07-22 2:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-18 8:43 O_DIRECT read and holes in 2.5.26 Stephen Lord
2002-07-22 2:26 ` Andrew Morton [this message]
2002-07-22 3:22 ` Anton Altaparmakov
2002-07-22 4:30 ` Andrew Morton
2002-07-26 20:22 ` Stephen Lord
2002-07-26 20:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D3B6D57.BB5C0F38@zip.com.au \
--to=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lord@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox