[PATCH] 2.5.27 Logitech Busmouse new driver FIX

[PATCH] 2.5.27 Logitech Busmouse new driver FIX

[Osamu Tomita]

[-- Attachment #1: Type: text/plain, Size: 115 bytes --]

Hi.
2.5.26-27 Logitech Busmouse driver doesn't work.
This patch fix it.
-- 
Osamu Tomita
E-mail: tomita@cinet.co.jp

[-- Attachment #2: linux-2.5.27-logibm.patch --]
[-- Type: application/octet-stream, Size: 1111 bytes --]

--- logibm.c.AT	Sun Jul 21 04:11:20 2002
+++ logibm.c.lkml	Mon Jul 22 16:58:22 2002
@@ -125,13 +125,14 @@
 	outb(LOGIBM_READ_Y_HIGH, LOGIBM_CONTROL_PORT);
 	buttons = inb(LOGIBM_DATA_PORT);
 	dy |= (buttons & 0xf) << 4;
-	buttons = ~buttons;
+	buttons = ~buttons >> 5;
 
 	input_report_rel(&logibm_dev, REL_X, dx);
-	input_report_rel(&logibm_dev, REL_Y, 255 - dy);
-	input_report_key(&logibm_dev, BTN_MIDDLE, buttons & 1);
-	input_report_key(&logibm_dev, BTN_LEFT,   buttons & 2);
-	input_report_key(&logibm_dev, BTN_RIGHT,  buttons & 4);
+	input_report_rel(&logibm_dev, REL_Y, dy);
+	input_report_key(&logibm_dev, BTN_RIGHT,  buttons & 1);
+	input_report_key(&logibm_dev, BTN_MIDDLE, buttons & 2);
+	input_report_key(&logibm_dev, BTN_LEFT,   buttons & 4);
+	outb(LOGIBM_ENABLE_IRQ, LOGIBM_CONTROL_PORT);
 }
 
 #ifndef MODULE
@@ -147,7 +148,7 @@
 
 static int __init logibm_init(void)
 {
-	if (request_region(LOGIBM_BASE, LOGIBM_EXTENT, "logibm")) {
+	if (!request_region(LOGIBM_BASE, LOGIBM_EXTENT, "logibm")) {
 		printk(KERN_ERR "logibm.c: Can't allocate ports at %#x\n", LOGIBM_BASE);
 		return -EBUSY;
 	}

Re: [PATCH] 2.5.27 Logitech Busmouse new driver FIX

[Vojtech Pavlik]

On Mon, Jul 22, 2002 at 08:55:00PM +0900, Osamu Tomita wrote:

> Hi.
> 2.5.26-27 Logitech Busmouse driver doesn't work.
> This patch fix it.
> -- 
> Osamu Tomita
> E-mail: tomita@cinet.co.jp

Thanks. Patch applied, and you should see it soon in a 2.5 kernel.

-- 
Vojtech Pavlik
SuSE Labs