Alan Cox wrote: > On Mon, 2002-07-22 at 15:08, Marcin Dalecki wrote: > >>- It is fixing completely confused wild casting to 32 bits. >> >>- Actually adding a comment explaining the obscure code, which is >> relying on integer arithmetics overflow. > > > Better yet take the code from 2.4.19-rc3. The code you fixed up is still > wrong. Sincie iov_len is not permitted to exceed 2Gb (SuS v3, found by > the LSB test suite) the actual fix turns out to be even simpler and > cleaner than the one you did You are right. It makes sese, since readv and writev are supposed to return ssize_t. Fixed patch version attached.