Re: [PATCH] reduce code in generic spinlock.h

Dave Hansen
2002-07-23T16:38:47Z

Robert Love wrote:
> On Tue, 2002-07-23 at 09:28, Dave Hansen wrote:
>
>>The last time lockmeter was ported to 2.5, it was getting a little
>>messy. There were separate declarations for spin_*lock() for each
>>combination of lockmeter and preemption, which made four, plus the
>>no-smp definition. While lockmeter's mess isn't the kernel's fault,
>>we noticed some some simplifications which could be made to the
>>generic spinlock code. This patch uses a single definition for each
>>of the macros, eliminating some redundant code.
>
> I have no problems with this (assuming it is right and it looks so on
> first glance).
>
> It will not apply to Linus's current tree, however, because of the IRQ
> rewrite that is now applied. If you pull his BK tree and diff against
> that, you should be OK... most notably, the preemption code has moved to
> preempt.h.

D'oh. Bad timing, I guess. I'll rediff against current BK.