Re: please DON'T run 2.5.27 with IDE!

Marcin Dalecki
2002-07-24T13:40:22Z

Jens Axboe wrote:

>>>>My goal is to make sure that the QUEUE_FLAG_STOPPED has a valid value
>>>>*inside* the q->request_fn call.
>>>
>>>So you want the queue_lock to protect the flags as well... I don't
>>>really see the point of this.
>>
>>If driver corectly uses blk_start/stop_queue() it is not needed.
>>Whole point of introducing this flag was not to take lock to check
>>status of queue.
>
>
> Right. The way it was meant to be used it how cpqarray and cciss does
> it -- stopping queue in request_fn, restarting it from isr.

Yes got it. Of course. But please note that:

1. My suggestion doesn't change the checking case.

2. What you describe is precisely what I would like to be able to
do in my own "playground".