From: Andrew Morton <akpm@zip.com.au>
To: Andrea Arcangeli <andrea@suse.de>
Cc: David F Barrera <dbarrera@us.ibm.com>, linux-kernel@vger.kernel.org
Subject: Re: kernel BUG at page_alloc.c:92! & page allocation failure. order:0, mode:0x0
Date: Wed, 24 Jul 2002 13:11:44 -0700 [thread overview]
Message-ID: <3D3F0A00.51C112C1@zip.com.au> (raw)
In-Reply-To: 20020724195503.GD1180@dualathlon.random
Andrea Arcangeli wrote:
>
> On Wed, Jul 24, 2002 at 12:35:54PM -0700, Andrew Morton wrote:
> > And please drop the ptrace.c change and use
> > http://www.zip.com.au/~akpm/linux/patches/2.5/2.5.27/lru-removal.patch
> > instead.
>
> page_cache_release() can return a #define to __free_page().
>
Man, it can do a ton more than that. This patch is just a stopgap
to prevent the oops.
page_cache_release() goes out onto the bus for the PageReserved()
test and then immediately goes out onto the bus again to perform the
atomic_dec_and_test(). Plus it tends to do all this inside
a global lock. That PageReserved thing needs to go away.
Seriously, this stuff needs a truck driven through it. See
http://mail.nl.linux.org/linux-mm/2002-07/msg00009.html and things
like pagevec_release(). It still needs quite some work, but the
optimisations which are available here are considerable.
-
next prev parent reply other threads:[~2002-07-24 20:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-24 13:42 kernel BUG at page_alloc.c:92! & page allocation failure. order:0, mode:0x0 David F Barrera
2002-07-24 19:35 ` Andrew Morton
2002-07-24 19:55 ` Andrea Arcangeli
2002-07-24 20:11 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-07-25 14:02 David F Barrera
2002-07-23 17:07 David F Barrera
2002-07-23 17:17 ` Rik van Riel
2002-07-23 18:17 ` Paul Larson
2002-07-23 16:56 David F Barrera
2002-07-23 19:24 ` Andrew Morton
2002-07-23 20:34 ` Andrea Arcangeli
2002-07-23 20:47 ` Andrew Morton
2002-07-23 20:56 ` Andrea Arcangeli
2002-07-23 21:16 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D3F0A00.51C112C1@zip.com.au \
--to=akpm@zip.com.au \
--cc=andrea@suse.de \
--cc=dbarrera@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox