From: Oleg Nesterov <oleg@tv-sign.ru>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch] irqlock patch 2.5.27-H4
Date: Fri, 26 Jul 2002 08:45:17 +0400 [thread overview]
Message-ID: <3D40D3DD.2242B3F6@tv-sign.ru> (raw)
Hello.
arch/i386/kernel/microcode.c:do_microcode_update() calls
smp_call_function(do_update_one). do_update_one() does
spin_lock/unlock. So smp_call_function_interrupt() needs
irq_enter().
entry.S has unneeded GET_THREAD_INFO(%ebx) in
device_not_available() trap.
Patch against 2.5.28.
--- arch/i386/kernel/smp.c~ Fri Jul 26 07:49:03 2002
+++ arch/i386/kernel/smp.c Fri Jul 26 07:53:45 2002
@@ -646,7 +646,10 @@
/*
* At this point the info structure may be out of scope unless wait==1
*/
+ irq_enter();
(*func)(info);
+ irq_exit();
+
if (wait) {
mb();
atomic_inc(&call_data->finished);
--- arch/i386/kernel/entry.S~ Fri Jul 26 07:49:03 2002
+++ arch/i386/kernel/entry.S Fri Jul 26 07:57:48 2002
@@ -417,7 +417,6 @@
ENTRY(device_not_available)
pushl $-1 # mark this as an int
SAVE_ALL
- GET_THREAD_INFO(%ebx)
movl %cr0, %eax
testl $0x4, %eax # EM (math emulation bit)
jne device_not_available_emulate
Oleg.
next reply other threads:[~2002-07-26 4:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-26 4:45 Oleg Nesterov [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-07-26 5:51 [patch] irqlock patch 2.5.27-H4 Oleg Nesterov
2002-07-24 11:47 Ingo Molnar
2002-07-24 11:59 ` Christoph Hellwig
2002-07-24 12:08 ` Ingo Molnar
2002-07-24 19:57 ` george anzinger
2002-07-24 13:13 ` Bartlomiej Zolnierkiewicz
2002-07-24 13:13 ` Marcin Dalecki
2002-07-24 13:23 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D40D3DD.2242B3F6@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox