Re: [patch 2/13] remove pages from the LRU in __free_pages_ok()

Linus Torvalds
2002-07-29T04:24:27Z

On Sun, 28 Jul 2002, Andrew Morton wrote:
>
> I don't think it can happen in 2.4. In the truncate case,
> the page is taken off the LRU by hand. If do_flushpage()
> failed then the buffers still have a ref on the page, which
> is undone in shrink_cache(), inside pagemap_lru_lock.
>
> So, probably safe, but way too subtle.

That was by no means "subtle", it was all very much "design".

Just undo the broken patch by Rik, and we should all be home free again.

Linus