Re: [patch] disable READA

Jeff Garzik
2002-07-30T21:41:12Z

Andrew Morton wrote:
> There's a bug in bread() which can cause it to misinterpret a
> failed READA request as an IO error on SMP.

> --- 2.4.19-rc3/drivers/block/ll_rw_blk.c~no-readahead Tue Jul 30 14:18:17 2002
> +++ 2.4.19-rc3-akpm/drivers/block/ll_rw_blk.c Tue Jul 30 14:19:52 2002
> @@ -841,7 +841,9 @@ static int __make_request(request_queue_
> rw_ahead = 0; /* normal case; gets changed below for READA */
> switch (rw) {
> case READA:
> +#if 0 /* bread() misinterprets failed READA attempts as IO errors on SMP */
> rw_ahead = 1;
> +#endif

If the problem is only on SMP, then that should be #ifndef CONFIG_SMP...

Jeff