From: Marcin Dalecki <dalecki@evision.ag>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: martin@dalecki.de, linux-kernel@vger.kernel.org
Subject: Re: Patch?: linux-2.5.29-ide109 small bio-based cleanup
Date: Wed, 31 Jul 2002 22:34:43 +0200 [thread overview]
Message-ID: <3D4849E3.30604@evision.ag> (raw)
In-Reply-To: 200207302254.PAA00504@baldur.yggdrasil.com
Adam J. Richter wrote:
> linux-2.5.29/drivers/ide/pcidma.c has a bunch of code in
> udma_new_table to work around transfers that cross 64kB boundaries
> and transfers that are exactly 64kB when the IDE chipset might only
> be able to handle transfers of *less than* 64kB. However, the current
> bio code already has limits that you can set to tell it never to send
> IO requests with those problems (blk_queue_segement_boundary and
> blk_queue_max_segment_size).
>
> The following patch makes the IDE code use the bio facilities
> to set these limits, and deletes the code that was needed to work
> around these cases. This shrinks the code by a net of 29 lines,
> and may allow for a tiny bit of space savings in the future,
> now that we know that none of the scatterlist entries that
> pci_map_sg returns will have to be split.
>
> I also got rid of an unnecessary variable and some
> extra data clearing and copying in init_hw_data.
>
> I am running this code now on the main that I'm using
> to compose this email.
Thanks! Great! Code immediately swallowed, since obviously correct :-).
However I will drop the CONFIG_CHIPSET outdefs, since at some
point in time we will make *every* host chip controller code
loadable at runtime.
prev parent reply other threads:[~2002-08-01 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-30 22:54 Patch?: linux-2.5.29-ide109 small bio-based cleanup Adam J. Richter
2002-07-31 20:34 ` Marcin Dalecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D4849E3.30604@evision.ag \
--to=dalecki@evision.ag \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@dalecki.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox