Re: cli/sti removal from linux-2.5.29/drivers/ide?

Alan Cox
2002-07-29T16:32:46Z

> With this change, I believe I can remove all of the
> cli()...restore_flags() pairs from the channel->tuneproc functions of
> each IDE driver. I have also removed what appear to be some

Some tuning locks are needed because an interrupt during the magic
tuning sequence will break stuff

g is ready, program the new timings
> */
> - spin_lock(&cmd640_lock, flags);
> + spin_lock_irqsave(&cmd640_lock, flags);
> /*

For the CMD640 please see the patch I posted. It has to use pci_lock and
it needs other 2.4 fixes forward porting which I did

> - save_flags(flags);
> - cli(); /* all CPUs (there should only be one CPU with this chipset) */
> + local_irq_save(flags); /* There should only be one CPU with this
> + chipset. */

Not needed that I can see. It also wants to use the proper master/mwi
functions. I've got a diff for this I can post.