From: Marcin Dalecki <dalecki@evision.ag>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: linux-kernel@vger.kernel.org, gerald@io.com, martin@dalecki.de
Subject: Re: 2.5.29: bug in ide and hd kernel option handling
Date: Thu, 01 Aug 2002 12:14:30 +0200 [thread overview]
Message-ID: <3D490A06.6070008@evision.ag> (raw)
In-Reply-To: 200208010101.DAA00248@harpo.it.uu.se
Mikael Pettersson wrote:
> On Tue, 30 Jul 2002, I wrote:
>
>>On my 486 test box (ISA/VLB only, CONFIG_PCI=n), passing any
>>any ide or hd kernel option (like idebus=33) to 2.5.29 results
>>in a kernel hang at boot: I get the initial "Uncompressing ..
>>booting .." and then nothing.
>
>
> Problem partially identified.
>
> With CONFIG_PCI=n, include/asm-i386/ide.h:ide_init_default_hwifs()
> is defined to ide_register_hw() the PC's standard IDE ports, but
> with CONFIG_PCI=y, it's empty.
>
> When drivers/ide/main.c:ide_setup() is called for some "ide..."
> kernel option, it starts by calling init_global_data(), which
> in turn calls ide_init_default_hwifs(). When CONFIG_PCI=n so
> ide_init_default_hwifs() isn't empty, the kernel either hangs
> or reboots at that point.
>
> init_global_data() and ide_init_default_hwifs() can also be called
> much later from 'module_init(init_ata)'. In that case there is no
> hang or reboot -- so my guess is that the initialisation does something
> which normally works but is illegal and causes a fault when done
> at __setup()-time.
>
> I tested every kernel from 2.5.29 and back, and the problem started
> with 2.5.5.
>
> As a workaround I applied the patch below to unconditionally
> make ide_init_default_hwifs() do nothing. This solved my problem
> and doesn't seem to have had any bad side-effects: the kernel still
> finds all standard IDE ports on my 486.
Ahh. Thats actually insightfull. OK some other archs even default to the
same if PCI bus support is enabled at all. I will have to test the
effects of this approach in bochs to see how it lives with "legacy"
host chips. Maybe this whole ide_init_default_hwifs can go completely
away then... (If anything it should be fallback only.)
next prev parent reply other threads:[~2002-08-01 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-01 1:01 2.5.29: bug in ide and hd kernel option handling Mikael Pettersson
2002-08-01 10:14 ` Marcin Dalecki [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-07-30 1:19 Gerald Champagne
2002-07-29 23:53 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D490A06.6070008@evision.ag \
--to=dalecki@evision.ag \
--cc=gerald@io.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@dalecki.de \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox