Re: linux-2.5.30uc0 MMU-less patches

Re: linux-2.5.30uc0 MMU-less patches

[Matthew Wilcox]

Some constructive criticism...

 - the Makefile changes seem terribly inappropriate.
 - you probably didn't mean to include page_alloc2.hack in the diff

 - Do you really need your own copy of fbcon.c?  Can it be merged with the
   one in drivers/video?
 - arch/m68knommu/console/68328fb.c should probably move to drivers/video
   too.
 - ditto most of the other files in the console directory ... 

 - Why are the changes to rd.c required?
 - I'm not sure it's appropriate to include the changes to nfs2xdr.c --
   is this a toolchain bug you're working around?

 - drivers/char/mcfserial.c needs to be converted to the new serial core
   and moved to drivers/serial.
 - ditto arch/m68knommu/platform/68360/quicc/uart.c

I'll look at the change you want to make to locks.c - I'm not terribly
fond of that interaction either.

-- 
Revolutions do not require corporate support.

Re: linux-2.5.30uc0 MMU-less patches

[gerg]

Hi Matthew,

Matthew Wilcox wrote:
> Some constructive criticism...

Thanks :-)


>  - the Makefile changes seem terribly inappropriate.

They are messy. Some are certainly required, for exmaple
to support the mmnommu directory. Some simplify cross compilation
(like the ARCH and CROSS_COMPILE changes). Some are just pedantic,
creating a binary named linux since this not a vmlinux system.

I'll look at simplify that.


>  - you probably didn't mean to include page_alloc2.hack in the diff

Removed.


>  - Do you really need your own copy of fbcon.c?  Can it be merged with the
>    one in drivers/video?

Looking at it I think it could.


>  - arch/m68knommu/console/68328fb.c should probably move to drivers/video
>    too.
>  - ditto most of the other files in the console directory ... 

Yep, looks like the whole thing should be merged/moved into
drivers/video.


>  - Why are the changes to rd.c required?

The include of linux/mm.h is too get some missing includes
(this is probably due to slightly different includes in something
in include/asm-m68knommu, but I haven't tracked it down yet).

The other change is too work around a compiler bug. Unfortunately
this just appeared in 2.5.30. Gcc is generating incorrect addressing
modes for the ColdFire arhcitecture. This is a short term fix until
the compiler is fixed right.


>  - I'm not sure it's appropriate to include the changes to nfs2xdr.c --
>    is this a toolchain bug you're working around?

Yes, same as above. I wouldn't expect anyone would want these
changes other than those specifically using ColdFire targets.


>  - drivers/char/mcfserial.c needs to be converted to the new serial core
>    and moved to drivers/serial.
>  - ditto arch/m68knommu/platform/68360/quicc/uart.c

Yep, I am looking at that now. That will take me a little
effort and time to put together.


> I'll look at the change you want to make to locks.c - I'm not terribly
> fond of that interaction either.

Thanks for the tips.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Wizard        EMAIL:  gerg@snapgear.com
Snapgear Pty Ltd                               PHONE:    +61 7 3279 1822
825 Stanley St,                                  FAX:    +61 7 3279 1820
Woolloongabba, QLD, 4102, Australia              WEB:   www.snapgear.com

Re: linux-2.5.30uc0 MMU-less patches

[Russell King]

On Sat, Aug 03, 2002 at 01:51:35AM +1000, gerg wrote:
> Matthew Wilcox wrote:
> >  - the Makefile changes seem terribly inappropriate.
> Some simplify cross compilation (like the ARCH and CROSS_COMPILE changes).

make ARCH=foo CROSS_COMPILE=arm-linux-

variables on makes command line override variables in the makefile.

> >  - drivers/char/mcfserial.c needs to be converted to the new serial core
> >    and moved to drivers/serial.
> >  - ditto arch/m68knommu/platform/68360/quicc/uart.c
> 
> Yep, I am looking at that now. That will take me a little
> effort and time to put together.

You should be aware that I'm going to be submitting a minor change in
the interface (as detailed in Documentation/serial/driver) soon, mainly
to make Dave Miller happy.  Patch soon to be available.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: linux-2.5.30uc0 MMU-less patches

[gerg]

Hi Russell,

Russell King wrote:
> On Sat, Aug 03, 2002 at 01:51:35AM +1000, gerg wrote:
> 
>>Matthew Wilcox wrote:
>>
>>> - the Makefile changes seem terribly inappropriate.
>>
>>Some simplify cross compilation (like the ARCH and CROSS_COMPILE changes).
> 
> 
> make ARCH=foo CROSS_COMPILE=arm-linux-
> 
> variables on makes command line override variables in the makefile.

That should help clean up that Makefile patch a bit :-)


>>> - drivers/char/mcfserial.c needs to be converted to the new serial core
>>>   and moved to drivers/serial.
>>> - ditto arch/m68knommu/platform/68360/quicc/uart.c
>>
>>Yep, I am looking at that now. That will take me a little
>>effort and time to put together.
> 
> 
> You should be aware that I'm going to be submitting a minor change in
> the interface (as detailed in Documentation/serial/driver) soon, mainly
> to make Dave Miller happy.  Patch soon to be available.

OK, I'll keep an eye out for that.

Thanks
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Wizard        EMAIL:  gerg@snapgear.com
Snapgear Pty Ltd                               PHONE:    +61 7 3279 1822
825 Stanley St,                                  FAX:    +61 7 3279 1820
Woolloongabba, QLD, 4102, Australia              WEB:   www.snapgear.com