Re: A new ide warning message

Marcin Dalecki
2002-08-06T12:49:40Z

Uz.ytkownik Bartlomiej Zolnierkiewicz napisa?:

> Look again Jens. Adam's changes made IDE queue handling inconsistent.
> hint: 2 * 127 != 255
>
> But noticed warning deals with design of ll_rw_blk.c. ;-)
> (right now max_segment_size have to be max bv->bv_len aligned)
>
> Jens, please look at segment checking/counting code, it does it on
> bv->bv_len (4kb most likely) not sector granuality...
>
> So for not 4kb aligned max_segment_size we will get new segment...
>
> Best fix will be to make block layer count sectors not bv->bv_len...
>
>
> btw. I like Adam's patch but it was draft not to include in mainline (?).

One never ever get's anything then drafts from Adam ;-) And since
I can't reproducde the breakage myself on any system I test
and since the patch looked really smooth...
Ej ej...