From: Chris Friesen <cfriesen@nortelnetworks.com>
To: linux-kernel@vger.kernel.org
Subject: flushing arp buffer -- why __skb_dequeue rather than __skb_dequeue_tail ?
Date: Thu, 08 Aug 2002 18:16:54 -0400 [thread overview]
Message-ID: <3D52EDD6.75150466@nortelnetworks.com> (raw)
As part of one of our test cases we ran into a scenario where we were sending
out messages while waiting on an arp reply. As expected they were buffered, but
we noticed that after the reply was received the packets were sent out in LIFO
order.
In neigh_update() in neighbor.c, we're looping through the list calling
__skb_dequeue(). Is there any particular reason why this was chosen rather than
__skb_dequeue_tail()? The latter would result in FIFO flushing of the buffer
which could have some benefits to udp applications that retry on out-of-order
message receipt, and it doesn't seem to be many more instructions, if any.
Besides, this isn't the fast path so a few extra instructions shouldn't matter.
Would you anticipate any odd side effects if we did change to FIFO flushing?
Chris
--
Chris Friesen | MailStop: 043/33/F10
Nortel Networks | work: (613) 765-0557
3500 Carling Avenue | fax: (613) 765-2986
Nepean, ON K2H 8E9 Canada | email: cfriesen@nortelnetworks.com
next reply other threads:[~2002-08-08 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-08 22:16 Chris Friesen [this message]
2002-08-09 13:34 ` flushing arp buffer -- why __skb_dequeue rather than __skb_dequeue_tail kuznet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D52EDD6.75150466@nortelnetworks.com \
--to=cfriesen@nortelnetworks.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox