Re: [PATCH] 2.5.30 IDE 115

[Marcin Dalecki <dalecki@evision.ag>]

Jens Axboe wrote:
> On Fri, Aug 09 2002, Marcin Dalecki wrote:
> 
>>- Fix small typo introduced in 113, which prevented CD-ROMs from
>>  working altogether.
> 
> 
> Have you fixed the sense reporting issue I told you about months ago?

Well at least ide-116 will start to unify the corresponding code.
But please don't expecty anything "revolutionary" yet... Just for
example using GPCMD_ constants throughout the code and a unified error
dissection function. One of the issues involved is rq->buffer in
ide-floppy versus rq->special in ide-cd.c


>>- Eliminate block_ioctl(). This code can't be shared in the way
>>  proposed by this file. We will port it to the proper
>>  blk_insert_request() soon. This will eliminate the _elv_add_request()
>>  "layering violation".
> 
> 
> What are you talking about?

Hmm, so apparently you where not the one who "inventid" it?

Anyway I talk about the block_ioctl.c file, which was supposed
to contain the two eject ioctl functions for "generic" packet code.
But since we don't have any kind of "generic" packet commands this
didn't make much sense.

It was inventing a function called blk_do_rq(), which was using
elv_add_request(). You called this not a long time ago a "layering
violation" yourself. And I simply intend to replace it in one of the
forthcomming patches  with the recently inventid blk_insert_request() 
function.

Oh, I realize I didn't express myself properly. I certinaly don't intend
to eliminate elv_add_request() itself any time soon ;-).