public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [patch 4/21] fix ARCH_HAS_PREFETCH
Date: Sun, 11 Aug 2002 00:38:38 -0700	[thread overview]
Message-ID: <3D56147E.15E7A98@zip.com.au> (raw)



include/linux/prefetch.h does a strange thing: if the arch doesn't have
the prefectch functions, this header defines no-op version of them and
then defines ARCH_HAS_PREFETCH.  So there's no way for mainline code to
know if the architecture *really* has prefetch instructions.

This information loss is unfortunate.  Examples:

	for (i = 0; i < N; i++)
		prefetch(foo[i]);

   Problem is, if `prefetch' is a no-op, the compiler will still
   generate an empty busy-wait loop.  Which it must do.  We need to
   know the truth about ARCH_HAS_PREFETCH to correctly elide that loop.


#ifdef ARCH_HAS_PREFETCH
#define prefetch_prev_lru_page(_page, _base, _field)                    \
        do {                                                            \
                if ((_page)->lru.prev != _base) {                       \
                        struct page *prev;                              \
                                                                        \
                        prev = list_entry(_page->lru.prev,              \
                                        struct page, lru);              \
                        prefetch(&prev->_field);                        \
                }                                                       \
        } while (0)
#else
#define prefetch_prev_lru_page(_page, _base, _field) do { } while (0)
#endif

Which needs a working ARCH_HAS_PREFETCH to avoid probable extra code
generation on CPUs which don't have prefetch.




 prefetch.h |    3 ---
 1 files changed, 3 deletions(-)

--- 2.5.31/include/linux/prefetch.h~arch_has_prefetchw	Sun Aug 11 00:20:08 2002
+++ 2.5.31-akpm/include/linux/prefetch.h	Sun Aug 11 00:20:08 2002
@@ -39,17 +39,14 @@
  */
  
 #ifndef ARCH_HAS_PREFETCH
-#define ARCH_HAS_PREFETCH
 static inline void prefetch(const void *x) {;}
 #endif
 
 #ifndef ARCH_HAS_PREFETCHW
-#define ARCH_HAS_PREFETCHW
 static inline void prefetchw(const void *x) {;}
 #endif
 
 #ifndef ARCH_HAS_SPINLOCK_PREFETCH
-#define ARCH_HAS_SPINLOCK_PREFETCH
 #define spin_lock_prefetch(x) prefetchw(x)
 #endif
 

.

             reply	other threads:[~2002-08-11  7:43 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-11  7:38 Andrew Morton [this message]
2002-08-11 19:49 ` [patch 4/21] fix ARCH_HAS_PREFETCH Alan Cox
2002-08-11 18:47   ` Andrew Morton
2002-08-11 18:46     ` Larry McVoy
2002-08-11 19:06     ` Linus Torvalds
2002-08-11 20:07       ` GCC still keeps empty loops? (was: [patch 4/21] fix ARCH_HAS_PREFETCH) Jamie Lokier
2002-08-12  7:45         ` Ralf Baechle
2002-08-13 21:42     ` [patch 4/21] fix ARCH_HAS_PREFETCH Adrian Bunk
2002-08-13 22:12       ` H. Peter Anvin
2002-08-13 22:22         ` Adrian Bunk
2002-08-13 22:42           ` H. Peter Anvin
2002-08-14 17:40         ` Rogier Wolff
2002-08-14 19:41           ` H. Peter Anvin
2002-08-14 19:57             ` Jamie Lokier
2002-08-14 22:03               ` Daniel Jacobowitz
2002-08-14 20:45             ` Willy Tarreau
2002-08-14 20:58               ` H. Peter Anvin
2002-08-14 21:11                 ` Willy Tarreau
2002-08-14 21:13                   ` H. Peter Anvin
2002-08-15  1:23                 ` Alan Cox
2002-08-15  1:28                   ` H. Peter Anvin
2002-08-15  1:37                     ` Alan Cox
2002-08-14 22:53               ` David Lang
2002-08-14 23:31                 ` Jamie Lokier
2002-08-15  6:44                 ` Willy Tarreau
2002-08-15  6:55                   ` H. Peter Anvin
     [not found] <3D56147E.15E7A98@zip.com.au.suse.lists.linux.kernel>
2002-08-11  9:53 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D56147E.15E7A98@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox