Re: [patch] tls-2.5.30-A1

Linus Torvalds
2002-08-07T18:29:09Z

On Wed, 7 Aug 2002, Ingo Molnar wrote:
>
> the attached patch (against BK-curr + Luca Barbieri's two TLS patches)
> does two things:
>
> - it implements a second TLS entry for Wine's purposes.

Guys, I really don't like how the segment map ends up getting uglier and
uglier.

I would suggest:
- move all kernel-related (and thus non-visible to user space) segments
up, and make the cacheline optimizations _there_.
- keep the TLS entries contiguous, and make sure that segment 0040 (ie
GDT entry #8) is available to a TLS entry, since if I remember
correctly, that one is also magical for old Windows binaries for all
the wrong reasons (ie it was some system data area in DOS and in
Windows 3.1)
- and for cleanliness bonus points: make the regular user data segments
just another TLS segment that just happens to have default values. If
the user wants to screw with its own segments, let it.

Then, for double extra bonus points somebody should look into whether
those damn PnP BIOS segments could be simply made to be TLS segments
during module init. I don't know if that PnP stuff is required later or
not.

Linus