From: Andrew Morton <akpm@zip.com.au>
To: Andrew Rodland <arodland@noln.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.5.31: modules don't work at all
Date: Mon, 12 Aug 2002 17:13:08 -0700 [thread overview]
Message-ID: <3D584F14.5D518E8D@zip.com.au> (raw)
In-Reply-To: 20020812200908.7e5331df.arodland@noln.com
Andrew Rodland wrote:
>
> > > - if (in_interrupt() || !mm)
> > > + if (preempt_count() || !mm)
> > > goto no_context;
> > >
> > > down_read(&mm->mmap_sem);
> > >
> >
> > Yes, that's the problem. qm_symbols() is performing copy_to_user()
> > inside lock_kernel() and that's an "atomic copy_to_user()" in 2.5.31.
> > But only if preempt is selected. The copy_to_user() doesn't work.
> >
> > There's nothing illegal about copy_to_user() inside lock_kernel().
>
> Does that mean that the above fix is a legal quick-fix and won't cause
> things to fall apart, or does it mean that I shouldn't bother until the
> next version?
That a legal quick-fix. Or disable CONFIG_PREEMPT.
next prev parent reply other threads:[~2002-08-13 0:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-12 2:33 2.5.31: modules don't work at all Adam J. Richter
2002-08-12 3:07 ` Skip Ford
2002-08-12 5:36 ` Andrew Morton
2002-08-12 17:22 ` Linus Torvalds
2002-08-12 17:52 ` Andrew Morton
2002-08-12 20:32 ` Linus Torvalds
2002-08-12 23:34 ` Andrew Morton
2002-08-12 23:45 ` Linus Torvalds
2002-08-13 0:32 ` Skip Ford
2002-08-13 1:31 ` Skip Ford
2002-08-13 0:09 ` Andrew Rodland
2002-08-13 0:13 ` Andrew Morton [this message]
2002-08-20 22:59 ` Ed Tomlinson
2002-08-12 3:09 ` Flanigan, Ryan
-- strict thread matches above, loose matches on Subject: below --
2002-08-11 12:41 Michel Eyckmans (MCE)
2002-08-12 0:54 ` Flanigan, Ryan
2002-08-12 1:03 ` Andrew Rodland
2002-08-12 1:11 ` Flanigan, Ryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D584F14.5D518E8D@zip.com.au \
--to=akpm@zip.com.au \
--cc=arodland@noln.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox