public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@zip.com.au>
To: Marcus Alanen <maalanen@ra.abo.fi>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch, 2.5] vmalloc.c error path fixes
Date: Tue, 20 Aug 2002 11:35:33 -0700	[thread overview]
Message-ID: <3D628BF5.26FBE772@zip.com.au> (raw)
In-Reply-To: Pine.LNX.4.44.0208202022100.16857-100000@tuxedo.abo.fi

Marcus Alanen wrote:
> 
> I think there are some problems in vmalloc.c.  The two first parts
> of the diff fix a spinlock being held if an error occurs in
> map_vm_area, and the last part fixes the error path of __vmalloc.

Certainly agree on the first chunk.  Listen to the old guy: "Thou
shalt not have more than one return statement per function".

Second chunk looks good too, but perhaps there's another way of doing
it.  The 2.5.31 code just tossed it all at vfree.  Perhaps hch can
comment?

  reply	other threads:[~2002-08-20 18:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-20 17:43 [patch, 2.5] vmalloc.c error path fixes Marcus Alanen
2002-08-20 18:35 ` Andrew Morton [this message]
2002-08-23 19:11   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D628BF5.26FBE772@zip.com.au \
    --to=akpm@zip.com.au \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maalanen@ra.abo.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox