RE: mdelay causes BUG, please use udelay

Martin J. Bligh
2002-08-21T16:02:24Z

>> - msec_delay(10);
>> + usec_delay(10000);
>
> Jeff, 10000 seems on the border of what's OK. If it's acceptable,
> then let's go for that. Otherwise, we're going to have to chain
> several mod_timer callbacks together to do a controller reset.

Whilst this sort of delay in interrupt context is undoubtedly bad
any way we do it, I'd question the context a little more before we
make a decision. This is called from e1000_reset_hw - are we likely
to ever actually call this except under initialisation? If we just
do it once on system boot, I'd say evil hacks (like this) are
acceptable. If we're going to do this under load, it definitely
needs fixing.

FWIW, this is heavily tested under Apache webserver load on a maxed
out 8 CPU system with at least 4 (8?) gigabit ethernet cards. Whilst
undoubtedly ugly, it's better than what we have now, so might I
suggest that we do this for now until a real fix is forthcoming if
we decide it's needed?

Martin.