More on EFS bug

More on EFS bug

[Peter Hicks]

Hi Alan

Here's a little more on the problem.

I've restarted my system, and I could mount the CD fine - modprobe efs, and
the kernel recognises the filesystem without a helping hand.  I noticed I was
using ide-scsi.o for writing last night, so I modprobe'd in scsi_mod,
sr_mod, cdrom and ide-scsi, mounted the CD, and instant problem.

The problem isn't the freshly burnt CD, as I tried with the original SGI CD,
which shows the same problem using ide-scsi, but is fine when I access things
natively over IDE.

Hope the extra detail is of use.

Best wishes,


Peter.

Re: More on EFS bug

[Alan Cox]

> The problem isn't the freshly burnt CD, as I tried with the original SGI CD,
> which shows the same problem using ide-scsi, but is fine when I access things
> natively over IDE.

That confirms my suspicion. Patch below. The bug cases should now error
politely


--- fs/efs/super.c~	2002-08-21 20:40:27.000000000 +0100
+++ fs/efs/super.c	2002-08-21 20:40:27.000000000 +0100
@@ -141,7 +141,13 @@
 	s->s_magic		= EFS_SUPER_MAGIC;
 	s->s_blocksize		= EFS_BLOCKSIZE;
 	s->s_blocksize_bits	= EFS_BLOCKSIZE_BITS;
-	set_blocksize(dev, EFS_BLOCKSIZE);
+	
+	if( set_blocksize(dev, EFS_BLOCKSIZE) < 0)
+	{
+		printk(KERN_ERR "EFS: device does not support %d byte blocks\n",
+			EFS_BLOCKSIZE);
+		goto out_no_fs_ul;
+	}
   
 	/* read the vh (volume header) block */
 	bh = sb_bread(s, 0);

Re: More on EFS bug

[Peter Hicks]

Alan Cox wrote:

>>The problem isn't the freshly burnt CD, as I tried with the original SGI CD,
>>which shows the same problem using ide-scsi, but is fine when I access things
>>natively over IDE.
>>    
>>
>
>That confirms my suspicion. Patch below. The bug cases should now error
>politely
>
>  
>
Just to confirm the patch works like a treat.  Thank you very much for 
your help!

Best wishes,


Peter.