From: Manfred Spraul <manfred@colorfullife.com>
To: "H. J. Lu" <hjl@lucon.org>
Cc: Andrew Morton <akpm@zip.com.au>,
ink@jurassic.park.msu.ru, ggs@shiresoft.com,
linux-kernel@vger.kernel.org, torvalds@transmeta.com,
dhinds@zen.stanford.edu
Subject: Re: [Fwd: [PATCH] reduce size of bridge regions for yenta.c]
Date: Sun, 25 Aug 2002 18:37:14 +0200 [thread overview]
Message-ID: <3D6907BA.5020603@colorfullife.com> (raw)
In-Reply-To: 20020825075729.A14924@lucon.org
H. J. Lu wrote:
> I don't like it at all. That change is not right. Usually the PCI
> bridge before the CardBus bridge is transparent.
And what if the PCI bridge is not transparent? What if it's a server
with a riser card, and a cardbus bridge to attach a WLAN card? That
setup is quite common.
yenta.c doesn't contain error handling, and that should be fixed.
>
> H.J.
> On Sat, Aug 24, 2002 at 11:09:36PM -0700, Andrew Morton wrote:
>
>>You guys may need this...
IMHO both patches are needed:
The current code that detects transparent bridges [bridges that
implement subtractive decoding would be a better name] is bad, Ivan's
patch fixes that.
My patch adds error handling to yenta.c. It's not strictly needed,
because most PCI bridges in laptops forward all requests, and thus there
is enough iomem space for the 8 MB allocation, but the lack of error
handling [and lack of printks] just asks for trouble.
--
Manfred
next prev parent reply other threads:[~2002-08-25 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3D6874A0.5B110F6@zip.com.au>
2002-08-25 14:57 ` [Fwd: [PATCH] reduce size of bridge regions for yenta.c] H. J. Lu
2002-08-25 16:37 ` Manfred Spraul [this message]
2002-08-27 19:34 ` H. J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D6907BA.5020603@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=akpm@zip.com.au \
--cc=dhinds@zen.stanford.edu \
--cc=ggs@shiresoft.com \
--cc=hjl@lucon.org \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox