From: Manfred Spraul <manfred@colorfullife.com>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: [patch 2.5.31] transparent PCI-to-PCI bridges
Date: Sun, 25 Aug 2002 18:55:59 +0200 [thread overview]
Message-ID: <3D690C1F.1090604@colorfullife.com> (raw)
Ivan wrote:
> + /*
> + * The PCI-to-PCI bridge spec requires that subtractive decoding
> + * (i.e. transparent) bridge must have programming interface code
> + * of 0x01.
> + */
> + if (dev->class & 1) {
> + printk("Transparent bridge - %s\n", dev->name);
Why not
if ((dev->class & 0xff) == 0x01)
Is the lowest bit an indicator of subtractive decoding, or is
Progif==0x01 the indicator of subtractive decoding?
The code and the comment should match.
--
Manfred
next reply other threads:[~2002-08-25 16:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-25 16:55 Manfred Spraul [this message]
2002-08-26 13:57 ` [patch 2.5.31] transparent PCI-to-PCI bridges Ivan Kokshaysky
2002-08-26 17:42 ` Linus Torvalds
2002-08-28 0:58 ` Ivan Kokshaysky
2002-08-28 1:29 ` Linus Torvalds
2002-08-30 21:38 ` [patch 2.5.32] " Ivan Kokshaysky
2002-08-26 20:12 ` [patch 2.5.31] " Benjamin Herrenschmidt
2002-08-28 1:40 ` Ivan Kokshaysky
2002-08-28 10:03 ` Benjamin Herrenschmidt
2002-08-28 17:35 ` Linus Torvalds
2002-08-28 18:35 ` Benjamin Herrenschmidt
2002-08-29 23:53 ` Ivan Kokshaysky
2002-08-30 9:28 ` Benjamin Herrenschmidt
2002-08-30 21:57 ` Ivan Kokshaysky
2002-08-30 20:19 ` Benjamin Herrenschmidt
2002-08-31 10:42 ` Ivan Kokshaysky
2002-08-31 15:06 ` Alan Cox
2002-08-31 16:49 ` Linus Torvalds
2002-08-31 22:40 ` Ivan Kokshaysky
2002-08-31 8:09 ` Benjamin Herrenschmidt
2002-08-30 17:12 ` Linus Torvalds
2002-08-30 22:23 ` Ivan Kokshaysky
2002-08-31 8:09 ` Benjamin Herrenschmidt
2002-08-31 13:12 ` Ivan Kokshaysky
2002-08-31 16:29 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2002-08-24 20:17 Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D690C1F.1090604@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox