From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Dave Hansen <haveblue@us.ibm.com>,
Michael Obster <michael.obster@bingo-ev.de>,
linux-kernel@vger.kernel.org
Subject: Re: Compiling 2.5.32
Date: Thu, 29 Aug 2002 19:24:43 -0400 [thread overview]
Message-ID: <3D6EAD3B.6030108@mandrakesoft.com> (raw)
In-Reply-To: Pine.NEB.4.44.0208300113410.2879-100000@mimas.fachschaften.tu-muenchen.de
Adrian Bunk wrote:
> Jeff Garzik doesn't want 1. until "someone actually tells me they are
> trying to hot-plug such a card" and he didn't apply the following patch to
> #ifdef the .remove away if the driver is compiled statically into the
> kernel:
>
>
> --- drivers/net/tulip/de2104x.c.old 2002-08-30 01:06:09.000000000 +0200
> +++ drivers/net/tulip/de2104x.c 2002-08-30 01:06:45.000000000 +0200
> @@ -2216,7 +2216,9 @@
> .name = DRV_NAME,
> .id_table = de_pci_tbl,
> .probe = de_init_one,
> +#ifdef MODULE
> .remove = de_remove_one,
> +#endif
> #ifdef CONFIG_PM
> .suspend = de_suspend,
> .resume = de_resume,
You missed my recent message, I think.
Currently in 2.5.x, you should be able to replace that #ifdef with
__devexit_p -- without changing the de_remove_one prototype. I updated
the definition of __devexit_p in 2.5.30 or so.
Jeff
next prev parent reply other threads:[~2002-08-29 23:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-29 20:09 Compiling 2.5.32 Michael Obster
2002-08-29 20:23 ` Dave Hansen
2002-08-29 23:20 ` Adrian Bunk
2002-08-29 23:24 ` Jeff Garzik [this message]
2002-08-29 23:42 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D6EAD3B.6030108@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=bunk@fs.tum.de \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.obster@bingo-ev.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox