public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Brownell <david-b@pacbell.net>
To: Greg KH <greg@kroah.com>
Cc: linux-usb-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Patrick Mochel <mochel@osdl.org>
Subject: Re: [linux-usb-devel] [RFC] USB driver conversion to "struct device_driver" for 2.5.32
Date: Thu, 29 Aug 2002 16:50:11 -0700	[thread overview]
Message-ID: <3D6EB333.7050509@pacbell.net> (raw)
In-Reply-To: 20020829221339.GA5074@kroah.com

So to be sure I've got this right ... those modified driver
entry points change things as follows:

> +	int (*probe) (struct usb_interface *intf,
> +		      const struct usb_device_id *id);

  (a) the device (for urbs etc) is now implicit:
        struct usb_device *dev = interface_to_usbdev (int):

  (b) the interface index should no longer matter

  (c) returns 0 (not void *) or -Errno (not null)

  (d) that void * handle is explicitly intf->dev.driver_data

> +	void (*disconnect) (struct usb_interface *intf);

   (a) and (d) above: same change

Makes me wonder about intf->private_data, which was the
original version of intf->dev.driver_data.  Shouldn't that
be removed too?  It's only used in the interface claiming
calls (shouldn't they fit in with the driver model?) and
usbfs just now.  Is that the usbfs work you mentioned?

- Dave




  parent reply	other threads:[~2002-08-30  0:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-22 20:44 [RFC] USB driver conversion to "struct device_driver" for 2.5.31 Greg KH
2002-08-23 19:31 ` Greg KH
     [not found] ` <20020829221339.GA5074@kroah.com>
2002-08-29 23:50   ` David Brownell [this message]
2002-08-30  3:46     ` [linux-usb-devel] [RFC] USB driver conversion to "struct device_driver" for 2.5.32 Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D6EB333.7050509@pacbell.net \
    --to=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=mochel@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox