2.4.20pre5 e100 build error + trivial fix

2.4.20pre5 e100 build error + trivial fix

[Andreas Steinmetz]

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

Hi,
the e100 driver in 2.4.20pre5 fails to build due to a static procedure 
declaration with an unresolved symbol (see below), trivial patch to fix 
this is attached.

ld -m elf_i386 -T 
/usr/src/ARCHIVE/kernel-2.4.20pre5/linux/arch/i386/vmlinux.lds -e stext 
arch/i386/kernel/head.o arch/i386/kernel/init_task.o init/main.o 
init/version.o init/do_mounts.o \
         --start-group \
         arch/i386/kernel/kernel.o arch/i386/mm/mm.o kernel/kernel.o 
mm/mm.o fs/fs.o ipc/ipc.o \
          drivers/char/char.o drivers/block/block.o drivers/misc/misc.o 
drivers/net/net.o drivers/media/media.o drivers/ide/idedriver.o 
drivers/cdrom/driver.o drivers/pci/driver.o drivers/video/video.o \
         net/network.o \
          \
         /usr/src/ARCHIVE/kernel-2.4.20pre5/linux/arch/i386/lib/lib.a 
/usr/src/ARCHIVE/kernel-2.4.20pre5/linux/lib/lib.a 
/usr/src/ARCHIVE/kernel-2.4.20pre5/linux/arch/i386/lib/lib.a \
         --end-group \
         -o vmlinux
drivers/net/net.o: In function `e100_diag_config_loopback':
drivers/net/net.o(.text+0x8a74): undefined reference to 
`e100_force_speed_duplex'

-- 
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH

[-- Attachment #2: e100_phy.diff --]
[-- Type: text/plain, Size: 276 bytes --]

--- drivers/net/e100/e100_phy.c.orig	2002-09-05 00:35:38.000000000 +0200
+++ drivers/net/e100/e100_phy.c	2002-09-05 01:03:32.000000000 +0200
@@ -622,7 +622,7 @@
  * Returns: void
  *
  */
-static void
+void
 e100_force_speed_duplex(struct e100_private *bdp)
 {
 	u16 control;

Re: 2.4.20pre5 e100 build error + trivial fix

[Jeff Garzik]

Andreas Steinmetz wrote:
> Hi,
> the e100 driver in 2.4.20pre5 fails to build due to a static procedure 
> declaration with an unresolved symbol (see below), trivial patch to fix 
> this is attached.
> ------------------------------------------------------------------------
> 
> --- drivers/net/e100/e100_phy.c.orig	2002-09-05 00:35:38.000000000 +0200
> +++ drivers/net/e100/e100_phy.c	2002-09-05 01:03:32.000000000 +0200
> @@ -622,7 +622,7 @@
>   * Returns: void
>   *
>   */
> -static void
> +void
>  e100_force_speed_duplex(struct e100_private *bdp)
>  {
>  	u16 control;


This is already sent to Marcelo for 2.4.x...