Re: [linux-usb-devel] Re: [BK PATCH] USB changes for 2.5.34

Jeff Garzik
2002-09-10T18:43:52Z

Linus Torvalds wrote:
> On Tue, 10 Sep 2002, David S. Miller wrote:
>
>>
>> IMO we should have ASSERT() and OHSHIT(),
>>
>>I fully support the addition of an OHSHIT() macro.
>
>
> Oh, please no. We'd end up with endless asserts in the networking layer,
> just because David would find it amusing.

hehe :)

> I think the approach should clearly spell what the trouble level is:
>
> DEBUG(x != y, "x=%d, y=%d\n", x, y);
>
> WARN(x != y, "crap happens: x=%d y=%d\n", x, y);
>
> FATAL(x != y, "Aiee: x=%d y=%d\n", x, y);

I like, that would allow me to kill per-file debug code in some of my
net drivers...

Jeff