Re: invalidate_inode_pages in 2.5.32/3

Andrew Morton
2002-09-05T19:14:54Z

Chuck Lever wrote:
>
> On Thu, 5 Sep 2002, Andrew Morton wrote:
>
> > That all assumes SMP/preempt. If you're seeing these problems on
> > uniproc/non-preempt then something fishy may be happening.
>
> sorry, forgot to mention: the system is UP, non-preemptible, high mem.
>
> invalidate_inode_pages isn't freeing these pages because the page count is
> two. perhaps the page count semantics of one of the page cache helper
> functions has changed slightly. i'm still diagnosing.

OK, thanks. I can't immediately think of anything which would have
altered the refcounting in there except for page reclaim.

What you could do is to check whether the `page_count(page) != 1'
pages are on the LRU. If they have !PageLRU(page) then the extra
ref was taken by shrink_cache(). But that would be pretty rare,
especially on UP.

You may have more success using the stronger invalidate_inode_pages2().