From: Andreas Steinmetz <ast@domdv.de>
To: Urban Widmark <urban@teststation.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: compile warning fix for smb_debug.h
Date: Sat, 14 Sep 2002 10:53:13 +0200 [thread overview]
Message-ID: <3D82F8F9.4080604@domdv.de> (raw)
In-Reply-To: Pine.LNX.4.44.0209141023420.32154-100000@cola.enlightnet.local
I'm just wary about the extra blank which is error prone. Otherwise
there's no problem.
Urban Widmark wrote:
> On Fri, 13 Sep 2002, Andreas Steinmetz wrote:
>
>
>>Hi,
>>attached is a fix for gcc 3.2 deprecated usage warnings for __FUNCTION__
>>in smb_debug.h. As gcc 2.95.3 doesn't issue the warning and can't handle
>>the new macro there's a macro selection based on the compiler major
>>version. Patch is against 2.4.20pre7.
>
>
> Why not just take the version from 2.5?
> Or is there a problem with this one too and gcc2.95.3?
>
> #ifdef SMBFS_PARANOIA
> # define PARANOIA(f, a...) printk(KERN_NOTICE "%s: " f, __FUNCTION__ , ## a)
> #else
> # define PARANOIA(f, a...) do { ; } while(0)
> #endif
>
> etc.
>
> Note the extra space ...
>
> /Urban
>
>
--
Andreas Steinmetz
D.O.M. Datenverarbeitung GmbH
next prev parent reply other threads:[~2002-09-14 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-13 17:38 compile warning fix for smb_debug.h Andreas Steinmetz
2002-09-14 8:28 ` Urban Widmark
2002-09-14 8:53 ` Andreas Steinmetz [this message]
2002-09-14 23:21 ` David Weinehall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D82F8F9.4080604@domdv.de \
--to=ast@domdv.de \
--cc=linux-kernel@vger.kernel.org \
--cc=urban@teststation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox