From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Albert Cranford <ac9410@attbi.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [patch 5/9]Four new i2c drivers and __init/__exit cleanup to i2c
Date: Sun, 15 Sep 2002 19:12:09 -0400 [thread overview]
Message-ID: <3D8513C9.2030709@mandrakesoft.com> (raw)
In-Reply-To: Pine.LNX.4.44.0209151839190.7637-200000@home1
Albert Cranford wrote:
> Hello Linus,
> New I2C drivers that have been adjusted after Russell King comments of August.
> o i2c-algo-8xx.c
> o i2c-pport.c
> o i2c-adap-ibm_ocp.c
> o i2c-pcf-epp.c
> o Add new drivers to Config.in and Makefile.
> o Add new drivers to i2c-core for initialization.
> o Remove EXPORT_NO_SYMBOLS statement from i2c-dev, i2c-elektor and i2c-frodo.
> o Cleanup init_module and cleanup_module adding __init and __exit to most drivers.
> o Adjust i2c-elektor with cli/sti replacement.
>
>
> ------------------------------------------------------------------------
>
> --- linux/drivers/i2c/i2c-dev.c.orig 2002-09-05 11:23:38.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-dev.c 2002-09-05 11:25:21.000000000 -0400
> @@ -544,8 +544,6 @@
> return 0;
> }
>
> -EXPORT_NO_SYMBOLS;
> -
> #ifdef MODULE
kill ifdef
> MODULE_AUTHOR("Frodo Looijaard <frodol@dds.nl> and Simon G. Vogl <simon@tk.uni-linz.ac.at>");
> --- linux/drivers/i2c/i2c-elektor.c.orig 2002-09-10 22:31:34.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-elektor.c 2002-09-10 22:31:58.000000000 -0400
> @@ -291,8 +291,6 @@
> return 0;
> }
>
> -EXPORT_NO_SYMBOLS;
> -
> #ifdef MODULE
> MODULE_AUTHOR("Hans Berglund <hb@spacetec.no>");
> MODULE_DESCRIPTION("I2C-Bus adapter routines for PCF8584 ISA bus adapter");
kill ifdef
> --- linux/drivers/i2c/i2c-frodo.c.orig 2002-09-05 11:23:59.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-frodo.c 2002-09-05 11:25:28.000000000 -0400
> @@ -97,8 +97,6 @@
> return (i2c_bit_add_bus (&frodo_ops));
> }
>
> -EXPORT_NO_SYMBOLS;
> -
> static void __exit i2c_frodo_exit (void)
> {
> i2c_bit_del_bus (&frodo_ops);
> @@ -111,8 +109,6 @@
> MODULE_LICENSE ("GPL");
> #endif /* #ifdef MODULE_LICENSE */
kill MODULE_LICENSE ifdef
>
> -EXPORT_NO_SYMBOLS;
> -
> module_init (i2c_frodo_init);
> module_exit (i2c_frodo_exit);
>
next prev parent reply other threads:[~2002-09-15 23:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-15 22:40 [patch 5/9]Four new i2c drivers and __init/__exit cleanup to i2c Albert Cranford
2002-09-15 23:12 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-09-15 22:41 Albert Cranford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D8513C9.2030709@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=ac9410@attbi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox