From: Roberto Nibali <ratz@drugphish.ch>
To: Kirk Reiser <kirk@braille.uwo.ca>
Cc: Skip Ford <skip.ford@verizon.net>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.35 undefined reference to `wait_task_inactive'
Date: Tue, 17 Sep 2002 16:54:35 +0200 [thread overview]
Message-ID: <3D87422B.3080300@drugphish.ch> (raw)
In-Reply-To: x7sn08k7r0.fsf@speech.braille.uwo.ca
>>A call to wait_task_inactive was added to fs/exec.c but that function is
>>not defined for UP.
> I haven't seen a fix for this yet?
Err, I've done and sent a possible patch to LKML, I'm simply not sure if
this is the right thing to do:
--- linux-2.5.35/kernel/sched.c Mon Sep 16 04:18:24 2002
+++ linux-2.5.35-ratz/kernel/sched.c Mon Sep 16 13:29:28 2002
@@ -331,8 +331,6 @@
#endif
}
-#ifdef CONFIG_SMP
-
/*
* wait_task_inactive - wait for a thread to unschedule.
*
@@ -366,7 +364,6 @@
task_rq_unlock(rq, &flags);
preempt_enable();
}
-#endif
/*
* kick_if_running - kick the remote CPU if the task is running currently.
BTW, ACPI needs a few tunings too to be able to compile the stuff as
modules, but I'm sure that also here it's not the right thing to do, I
simply did a quick hack to have a running and bootable 2.5.35 kernel:
diff -ur linux-2.5.35/drivers/acpi/hardware/hwgpe.c
linux-2.5.35-ratz/drivers/acpi/hardwar
e/hwgpe.c
--- linux-2.5.35/drivers/acpi/hardware/hwgpe.c Mon Sep 16 04:18:17 2002
+++ linux-2.5.35-ratz/drivers/acpi/hardware/hwgpe.c Mon Sep 16
12:49:40 2002
@@ -28,7 +28,9 @@
#include "acevents.h"
#define _COMPONENT ACPI_HARDWARE
+#ifdef MODULE
ACPI_MODULE_NAME ("hwgpe")
+#endif
/******************************************************************************
diff -ur linux-2.5.35/drivers/acpi/namespace/nsxfname.c
linux-2.5.35-ratz/drivers/acpi/nam
espace/nsxfname.c
--- linux-2.5.35/drivers/acpi/namespace/nsxfname.c Mon Sep 16
04:18:23 2002
+++ linux-2.5.35-ratz/drivers/acpi/namespace/nsxfname.c Mon Sep 16
13:00:34 2002
@@ -30,7 +30,9 @@
#define _COMPONENT ACPI_NAMESPACE
+#ifdef MODULE
ACPI_MODULE_NAME ("nsxfname")
+#endif
/****************************************************************************
diff -ur linux-2.5.35/drivers/acpi/namespace/nsxfobj.c
linux-2.5.35-ratz/drivers/acpi/name
space/nsxfobj.c
--- linux-2.5.35/drivers/acpi/namespace/nsxfobj.c Mon Sep 16
04:18:15 2002
+++ linux-2.5.35-ratz/drivers/acpi/namespace/nsxfobj.c Mon Sep 16
13:00:52 2002
@@ -30,7 +30,9 @@
#define _COMPONENT ACPI_NAMESPACE
+#ifdef MODULE
ACPI_MODULE_NAME ("nsxfobj")
+#endif
/*******************************************************************************
*
diff -ur linux-2.5.35/drivers/acpi/resources/rsdump.c
linux-2.5.35-ratz/drivers/acpi/resou
rces/rsdump.c
--- linux-2.5.35/drivers/acpi/resources/rsdump.c Mon Sep 16
04:18:30 2002
+++ linux-2.5.35-ratz/drivers/acpi/resources/rsdump.c Mon Sep 16
13:01:26 2002
@@ -28,7 +28,9 @@
#include "acresrc.h"
#define _COMPONENT ACPI_RESOURCES
+#ifdef MODULE
ACPI_MODULE_NAME ("rsdump")
+#endif
#if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
diff -ur linux-2.5.35/drivers/acpi/utilities/utdebug.c
linux-2.5.35-ratz/drivers/acpi/util
ities/utdebug.c
--- linux-2.5.35/drivers/acpi/utilities/utdebug.c Mon Sep 16
04:18:38 2002
+++ linux-2.5.35-ratz/drivers/acpi/utilities/utdebug.c Mon Sep 16
13:02:12 2002
@@ -27,7 +27,9 @@
#include "acpi.h"
#define _COMPONENT ACPI_UTILITIES
+#ifdef MODULE
ACPI_MODULE_NAME ("utdebug")
+#endif
#ifdef ACPI_DEBUG_OUTPUT
diff -ur linux-2.5.35/drivers/usb/storage/transport.c
linux-2.5.35-ratz/drivers/usb/storag
e/transport.c
--- linux-2.5.35/drivers/usb/storage/transport.c Mon Sep 16
04:18:26 2002
+++ linux-2.5.35-ratz/drivers/usb/storage/transport.c Mon Sep 16
12:46:47 2002
@@ -55,6 +55,8 @@
#include <linux/errno.h>
#include <linux/slab.h>
+extern void show_trace(unsigned long* esp);
+
/***********************************************************************
* Helper routines
***********************************************************************/
Best regards,
Roberto Nibali, ratz
--
echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq'|dc
next prev parent reply other threads:[~2002-09-17 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-16 6:44 2.5.35 undefined reference to `wait_task_inactive' Skip Ford
2002-09-17 14:31 ` Kirk Reiser
2002-09-17 14:54 ` Roberto Nibali [this message]
2002-09-17 15:05 ` Roberto Nibali
2002-09-17 15:13 ` Kirk Reiser
2002-09-17 15:08 ` Benjamin LaHaise
2002-09-17 15:21 ` Roberto Nibali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D87422B.3080300@drugphish.ch \
--to=ratz@drugphish.ch \
--cc=kirk@braille.uwo.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=skip.ford@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox