From: Roberto Nibali <ratz@drugphish.ch>
To: linux-kernel@vger.kernel.org
Subject: TLB flush counters gone in 2.5.35-bk?
Date: Tue, 17 Sep 2002 17:43:29 +0200 [thread overview]
Message-ID: <3D874DA1.20803@drugphish.ch> (raw)
Hello,
I was just browsing over the latest bk tree when I saw the following change:
--- a/include/asm-generic/tlb.h Thu Aug 29 13:27:24 2002
+++ b/include/asm-generic/tlb.h Mon Sep 9 14:58:18 2002
@@ -21,7 +21,7 @@
* and page free order so much..
*/
#ifdef CONFIG_SMP
- #define FREE_PTE_NR 507
+ #define FREE_PTE_NR 506
#define tlb_fast_mode(tlb) ((tlb)->nr == ~0U)
#else
#define FREE_PTE_NR 1
@@ -40,8 +40,6 @@
unsigned int fullmm; /* non-zero means full mm flush */
unsigned long freed;
struct page * pages[FREE_PTE_NR];
- unsigned long flushes;/* stats: count avoided flushes */
- unsigned long avoided_flushes;
} mmu_gather_t;
/* Users of the generic TLB shootdown code must declare this storage
space. */
@@ -67,17 +65,10 @@
static inline void tlb_flush_mmu(mmu_gather_t *tlb, unsigned long
start, unsigned long en
d)
{
- unsigned long nr;
-
- if (!tlb->need_flush) {
- tlb->avoided_flushes++;
+ if (!tlb->need_flush)
return;
- }
tlb->need_flush = 0;
- tlb->flushes++;
-
tlb_flush(tlb);
- nr = tlb->nr;
if (!tlb_fast_mode(tlb)) {
free_pages_and_swap_cache(tlb->pages, tlb->nr);
tlb->nr = 0;
Why was that done? I'm actually about to conduct some tests where I
think that I need this information to check the L1 <-> L2 caching size
influence on kernel data structures. What is the problem with the
existing counters, did I miss some discussion on LKML?
Best regards,
Roberto Nibali, ratz
--
echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq'|dc
next reply other threads:[~2002-09-17 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-17 15:43 Roberto Nibali [this message]
2002-09-17 20:55 ` TLB flush counters gone in 2.5.35-bk? Andrew Morton
[not found] <3D874DA1.20803@drugphish.ch.suse.lists.linux.kernel>
2002-09-17 16:59 ` Andi Kleen
2002-09-17 18:45 ` Roberto Nibali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D874DA1.20803@drugphish.ch \
--to=ratz@drugphish.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox