From: Andrew Morton <akpm@digeo.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: mm gang: you goofed!
Date: Wed, 18 Sep 2002 13:17:30 -0700 [thread overview]
Message-ID: <3D88DF5A.68E41C6B@digeo.com> (raw)
In-Reply-To: Pine.LNX.4.44.0209182006530.5607-100000@localhost.localdomain
Hugh Dickins wrote:
>
> ...
> It seems that __lookup() can easily return 0, even though there's
> more to find, if it starts partway into a RADIX_TREE_MAP_SIZE
> array, in which the only occupied slots are before it starts.
erk. That sounds right.
I don't think the max_index test matters much - if we ever
hit that index then something has gone horridly wrong, because
it's out-of-bounds for the tree height. But whatever.
> Patch below seems to fix it
But your patch only fixes the symptoms of the bug. You should
fix the real bug. But to do that you'd need to find me, so this
will have to do for now.
> but I bet you can improve upon it.
Well the colour scheme is a bit gaudy.
> Might this relate to Trond/Chuck's NFS invalidation woes?
Nope; this code is only in the mm crash-test-dummy tree at present.
And it's currently at the "wow, it worked first time" stage. I need
to get down and write some special test code for it, and to run
fsx-linux. Possibly fsx-linux has sufficient coverage.
> It's certainly the main contributor to my tmpfs problems.
Sorry about that.
> I look forward to your "erk" - or will you delight us with
> some other exclamation?!
gack?
prev parent reply other threads:[~2002-09-18 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-18 19:28 mm gang: you goofed! Hugh Dickins
2002-09-18 20:17 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D88DF5A.68E41C6B@digeo.com \
--to=akpm@digeo.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox