From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [BK/GNU] kill schedule_timeout(0) uses
Date: Sun, 22 Sep 2002 18:26:02 -0400 [thread overview]
Message-ID: <3D8E437A.1050800@mandrakesoft.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 88 bytes --]
GNU patch attached and CC'd to lkml to encourage an extra look-over
being applying...
[-- Attachment #2: misc-2.5.txt --]
[-- Type: text/plain, Size: 467 bytes --]
Linus, please do a
bk pull http://gkernel.bkbits.net/misc-2.5
This will update the following files:
drivers/cdrom/cdu31a.c | 3 +--
drivers/cdrom/sonycd535.c | 3 +--
drivers/net/sb1000.c | 8 ++++----
drivers/net/sis900.c | 4 ++--
4 files changed, 8 insertions(+), 10 deletions(-)
through these ChangeSets:
<jgarzik@mandrakesoft.com> (02/09/22 1.598)
s/schedule_timeout(0)/yield/ in cdu31a, sonycd535, sb1000, and sis900 drivers
[-- Attachment #3: patch --]
[-- Type: text/plain, Size: 2071 bytes --]
diff -Nru a/drivers/cdrom/cdu31a.c b/drivers/cdrom/cdu31a.c
--- a/drivers/cdrom/cdu31a.c Sun Sep 22 18:24:25 2002
+++ b/drivers/cdrom/cdu31a.c Sun Sep 22 18:24:25 2002
@@ -386,8 +386,7 @@
unsigned long flags;
if (cdu31a_irq <= 0) {
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(0);
+ yield();
} else { /* Interrupt driven */
save_flags(flags);
diff -Nru a/drivers/cdrom/sonycd535.c b/drivers/cdrom/sonycd535.c
--- a/drivers/cdrom/sonycd535.c Sun Sep 22 18:24:25 2002
+++ b/drivers/cdrom/sonycd535.c Sun Sep 22 18:24:25 2002
@@ -344,8 +344,7 @@
sony_sleep(void)
{
if (sony535_irq_used <= 0) { /* poll */
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(0);
+ yield();
} else { /* Interrupt driven */
cli();
enable_interrupts();
diff -Nru a/drivers/net/sb1000.c b/drivers/net/sb1000.c
--- a/drivers/net/sb1000.c Sun Sep 22 18:24:25 2002
+++ b/drivers/net/sb1000.c Sun Sep 22 18:24:25 2002
@@ -295,8 +295,8 @@
timeout = jiffies + TimeOutJiffies;
while (a & 0x80 || a & 0x40) {
/* a little sleep */
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(0);
+ yield();
+
a = inb(ioaddr[0] + 7);
if (jiffies >= timeout) {
printk(KERN_WARNING "%s: card_wait_for_busy_clear timeout\n",
@@ -319,8 +319,8 @@
timeout = jiffies + TimeOutJiffies;
while (a & 0x80 || !(a & 0x40)) {
/* a little sleep */
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(0);
+ yield();
+
a = inb(ioaddr[1] + 6);
if (jiffies >= timeout) {
printk(KERN_WARNING "%s: card_wait_for_ready timeout\n",
diff -Nru a/drivers/net/sis900.c b/drivers/net/sis900.c
--- a/drivers/net/sis900.c Sun Sep 22 18:24:25 2002
+++ b/drivers/net/sis900.c Sun Sep 22 18:24:25 2002
@@ -573,8 +573,8 @@
if(status & MII_STAT_LINK){
while (poll_bit) {
- current->state = TASK_INTERRUPTIBLE;
- schedule_timeout(0);
+ yield();
+
poll_bit ^= (mdio_read(net_dev, sis_priv->cur_phy, MII_STATUS) & poll_bit);
if (jiffies >= timeout) {
printk(KERN_WARNING "%s: reset phy and link down now\n", net_dev->name);
reply other threads:[~2002-09-22 22:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D8E437A.1050800@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox