Re: [ltt-dev] Re: [PATCH] LTT for 2.5.38 1/9: Core infrastructure

bob
2002-09-22T23:45:12Z

Ingo Molnar writes:
>
> On Sun, 22 Sep 2002, bob wrote:
>
> > However, for sake of argument, the above is still not true. A global
> > lock has a different (worse) performance problem then the lock-free
> > atomic operation even given a global queue. The difference is 1) the
> > Linux global lock is very expensive [... and interacts with potential
> > other processes, [...]
>
> huh? what is 'the Linux global lock'?

sorry - LTT just uses a global lock - but to do so it must disable
interrupts. This is not a cheap operation. With lockless code you do not
need to disable interrrupts (or grab a lock) -> many less cycles.

>
> > [...] and 2) you have to hold the lock for the entire duration of
> > logging the event; with the atomic operation you are finished once
> > you've reserved you space. [...]
>
> you dont have to hold the lock for the duration of saving the event, the
> lock could as well protect a 'current entry' index. (Not that those 2-3
> cycles saving off the event into a single cacheline counts that much ...)
>
> the tail-atomic method is precisely equivalent to a global spinlock. The
> tail of a global event buffer acts precisely as a global spinlock: if one
> CPU writes to it in a stream then it performs okay, if two CPUs trace in
> parallel then it causes cachelines to bounce like crazy.

If 2 cpus ping-pong back and forth there will be significant cache cost -
true, but the cost of having to acquire the lock (which also ping-pongs)
and disabling the interrupts, adds even more. The additional cache line
ping pong for the lock (latency probably won't be hidden in fetching the
trace buffer data) plus the disabling interrupts still more than doubles
the cost.

-bob

Robert Wisniewski
The K42 MP OS Project
Advanced Operating Systems
Scalable Parallel Systems
IBM T.J. Watson Research Center
914-945-3181
http://www.research.ibm.com/K42/
bob@watson.ibm.com